chore(core/types): header JSON and RLP serialization hooks (4) #746

darioush · 2025-01-13T23:14:45Z

Implement HeaderExtra RLP and JSON serialization methods
remove BlockNonce
remove EncodeNonce
new functions GetHeaderExtra and SetHeaderExtra
Migrate existing custom Header to HeaderSerializable in block_ext.go with only Hash method for RLP code generation
Rename files gen_header_json.go to gen_header_serializable_json.go
Rename files gen_header_rlp.go to gen_header_serializable_rlp.go

PS by qdm12: inappropriate branch name libevm-upstream-types for historical reasons

core/types/header_ext.go

consensus/dummy/consensus.go

core/types/header_ext.go

core/types/imports.go

core/types/libevm.go

core/types/header_ext.go

core/types/block.go

accounts/abi/bind/bind_test.go

- Uses tip of main libevm dependency + cherry picked commit: ava-labs/libevm@d3f6a5e - Precompile legacy gas fix (done in ava-labs/libevm@f906679) - Added `HeaderExtra` not-implemented implementation - Minimal changes shamelessly copied over from #746

qdm12

Self review

core/types/block.go

core/types/header_ext.go

core/types/block_ext_test.go

core/types/block.go

- gen_header_json.go -> gen_header_serializable_json.go - gen_header_rlp.go -> gen_header_serializable_rlp.go

Co-authored-by: Arran Schlosberg <[email protected]> Signed-off-by: Quentin McGaw <[email protected]>

ARR4N

Noting that force push was a no-op.

qdm12

Re-approving (given no-op force push)

- Implement `HeaderExtra` RLP and JSON serialization methods - remove `BlockNonce` - remove `EncodeNonce` - new functions `GetHeaderExtra` and `SetHeaderExtra` - Migrate existing custom `Header` to `HeaderSerializable` in block_ext.go with only `Hash` method for RLP code generation - Rename files gen_header_json.go to gen_header_serializable_json.go - Rename files gen_header_rlp.go to gen_header_serializable_rlp.go Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Quentin Mc Gaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]>

- Define `HeaderExtra` with `RLP` and `JSON` serialization methods - remove `BlockNonce` - remove `EncodeNonce` - new functions `GetHeaderExtra` and `SetHeaderExtra` - Migrate existing custom `Header` to `HeaderSerializable` in block_ext.go with only `Hash` method for RLP code generation - Rename files gen_header_json.go to gen_header_serializable_json.go - Rename files gen_header_rlp.go to gen_header_serializable_rlp.go See original PR ava-labs/coreth#746 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Quentin Mc Gaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]>

- Define `HeaderExtra` with `RLP` and `JSON` serialization methods - remove `BlockNonce` - remove `EncodeNonce` - new functions `GetHeaderExtra` and `SetHeaderExtra` - Migrate existing custom `Header` to `HeaderSerializable` in block_ext.go with only `Hash` method for RLP code generation - Rename files gen_header_json.go to gen_header_serializable_json.go - Rename files gen_header_rlp.go to gen_header_serializable_rlp.go See original PR ava-labs/coreth#746 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Quentin Mc Gaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]> Co-authored-by: Darioush Jalili <[email protected]>

- Define `HeaderExtra` with `RLP` and `JSON` serialization methods - remove `BlockNonce` - remove `EncodeNonce` - new functions `GetHeaderExtra` and `SetHeaderExtra` - Migrate existing custom `Header` to `HeaderSerializable` in block_ext.go with only `Hash` method for RLP code generation - Rename files gen_header_json.go to gen_header_serializable_json.go - Rename files gen_header_rlp.go to gen_header_serializable_rlp.go - Update avalanchego to prevent double core/types extra registration conflict See original PR ava-labs/coreth#746 Signed-off-by: Quentin McGaw <[email protected]> Co-authored-by: Quentin Mc Gaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]> Co-authored-by: Darioush Jalili <[email protected]>

- Define `HeaderExtra` with `RLP` and `JSON` serialization methods - remove `BlockNonce` - remove `EncodeNonce` - new functions `GetHeaderExtra` and `SetHeaderExtra` - Migrate existing custom `Header` to `HeaderSerializable` in block_ext.go with only `Hash` method for RLP code generation - Rename files gen_header_json.go to gen_header_serializable_json.go - Rename files gen_header_rlp.go to gen_header_serializable_rlp.go - Update avalanchego to prevent double core/types extra registration conflict See original PR ava-labs/coreth#746 Signed-off-by: Quentin Mc Gaw <[email protected]> Co-authored-by: Quentin Mc Gaw <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]> Co-authored-by: Darioush Jalili <[email protected]>

darioush changed the base branch from master to libevm January 13, 2025 23:14

qdm12 reviewed Jan 17, 2025

View reviewed changes

core/types/header_ext.go Show resolved Hide resolved

qdm12 reviewed Jan 21, 2025

View reviewed changes

This was referenced Feb 10, 2025

fix(deps): legacy precompile gas fix #784

Closed

chore(all): minimal changes for last libevm dependency (1) #785

Closed

qdm12 force-pushed the libevm-upstream-types branch from f133755 to ef168bd Compare February 10, 2025 15:20

qdm12 changed the title ~~[wip] use header type from libevm~~ chore(core/types): header JSON and RLP serialization hooks Feb 10, 2025

qdm12 changed the base branch from libevm to qdm12/libevm/structure February 10, 2025 15:22

qdm12 changed the title ~~chore(core/types): header JSON and RLP serialization hooks~~ chore(core/types): header JSON and RLP serialization hooks (3) Feb 10, 2025

qdm12 force-pushed the libevm-upstream-types branch 3 times, most recently from 269fb9c to d98039c Compare February 10, 2025 16:21

qdm12 force-pushed the qdm12/libevm/structure branch 2 times, most recently from 7093fc3 to 3e8d4e4 Compare February 12, 2025 12:30

qdm12 force-pushed the libevm-upstream-types branch from d98039c to d52d44f Compare February 12, 2025 12:43

qdm12 force-pushed the qdm12/libevm/structure branch from 3e8d4e4 to 806817d Compare February 12, 2025 12:53

qdm12 force-pushed the libevm-upstream-types branch 2 times, most recently from 59ef836 to c6f5f69 Compare February 12, 2025 12:55

qdm12 reviewed Feb 12, 2025

View reviewed changes

core/types/block.go Show resolved Hide resolved

core/types/header_ext.go Outdated Show resolved Hide resolved

core/types/header_ext.go Show resolved Hide resolved

core/types/header_ext.go Show resolved Hide resolved

qdm12 force-pushed the libevm-upstream-types branch from 6ac9728 to e0537f8 Compare February 12, 2025 14:59

qdm12 reviewed Feb 12, 2025

View reviewed changes

core/types/block_ext_test.go Show resolved Hide resolved

core/types/block.go Show resolved Hide resolved

qdm12 force-pushed the qdm12/libevm/structure branch from 806817d to 9165b01 Compare February 13, 2025 16:52

qdm12 force-pushed the libevm-upstream-types branch from e0537f8 to 22d5be0 Compare February 13, 2025 16:54

qdm12 force-pushed the qdm12/libevm/structure branch from 9165b01 to 514bcdb Compare February 14, 2025 13:29

qdm12 force-pushed the libevm-upstream-types branch from 22d5be0 to f743475 Compare February 14, 2025 13:29

This was referenced Feb 14, 2025

chore(core/types): small code restructure for future code changes (2) #800

Closed

chore(all): minimal changes for libevm v1.13.14-0.2.0.rc.3 (1) #811

Merged

qdm12 and others added 5 commits February 25, 2025 16:10

Rename generated codec files

aab9d7e

- gen_header_json.go -> gen_header_serializable_json.go - gen_header_rlp.go -> gen_header_serializable_rlp.go

Add note on custom generators used to support type aliases

56b296b

remove vmerrs (#829)

a7f9917

Simplify assertDifferentPointers to not rely on testify/assert

4d2f143

Revert to using assertNonZero function in allExportedFieldsSet

57a6734

qdm12 force-pushed the libevm-upstream-types branch from 8ca5efd to 57a6734 Compare February 25, 2025 15:13

Improve testHeaderEncodeDecode signature definition

d360c2c

Co-authored-by: Arran Schlosberg <[email protected]> Signed-off-by: Quentin McGaw <[email protected]>

qdm12 dismissed their stale review via d360c2c February 25, 2025 15:20

qdm12 requested a review from ARR4N February 25, 2025 15:24

ARR4N approved these changes Feb 25, 2025

View reviewed changes

qdm12 approved these changes Feb 25, 2025

View reviewed changes

Merge branch 'libevm' into libevm-upstream-types

949ce6d

qdm12 merged commit 0657877 into libevm Feb 25, 2025
6 checks passed

qdm12 deleted the libevm-upstream-types branch February 25, 2025 16:19

qdm12 mentioned this pull request Feb 26, 2025

chore(core/types): remove block.go and import Block and Body from libevm (6) #760

Merged

qdm12 mentioned this pull request Apr 8, 2025

fix(metrics/prometheus): skip metric types GaugeInfo #910

Merged

chore(core/types): header JSON and RLP serialization hooks (4) #746

chore(core/types): header JSON and RLP serialization hooks (4) #746

Uh oh!

Conversation

darioush commented Jan 13, 2025 • edited by qdm12 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qdm12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ARR4N left a comment

Choose a reason for hiding this comment

Uh oh!

qdm12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

darioush commented Jan 13, 2025 •

edited by qdm12

Loading